markrmiller commented on a change in pull request #214:
URL: https://github.com/apache/solr/pull/214#discussion_r672484107
##########
File path:
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java
##########
@@ -124,8 +124,18 @@ public Builder(int nodeCount, Path baseDir) {
// By default the MiniSolrCloudCluster being built will randomly (seed
based) decide which collection API strategy
// to use (distributed or Overseer based) and which cluster update
strategy to use (distributed if collection API
// is distributed, but Overseer based or distributed randomly chosen if
Collection API is Overseer based)
- this.useDistributedCollectionConfigSetExecution =
LuceneTestCase.random().nextInt(2) == 0;
- this.useDistributedClusterStateUpdate =
useDistributedCollectionConfigSetExecution ||
LuceneTestCase.random().nextInt(2) == 0;
+
+ Boolean skipDistRandomSetup =
Boolean.getBoolean("solr.tests.skipDistributedConfigAndClusterStateRandomSetup");
Review comment:
This is essentially a get it working hack at the moment. Ideally, it's
simpler to use MiniSolrCluster without having to worry about this
SolrCloudTestCase / carrot random tie in.
You really want a consistent experience when using the class itself. It's
running things via tests that should enable the randomization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
