markrmiller commented on a change in pull request #214:
URL: https://github.com/apache/solr/pull/214#discussion_r672482454
##########
File path: solr/test-framework/src/java/org/apache/solr/util/RandomizeSSL.java
##########
@@ -104,10 +105,10 @@ public SSLRandomizer(double ssl, double clientAuth,
String debug) {
public SSLTestConfig createSSLTestConfig() {
// even if we know SSL is disabled, always consume the same amount of
randomness
// that way all other test behavior should be consistent even if a user
adds/removes @SuppressSSL
-
- final boolean useSSL = TestUtil.nextInt(LuceneTestCase.random(), 0, 999)
<
+ Random random = new Random();
Review comment:
Because we use randoms differently in the benchmark stuff and don't want
to be stuck with Randomized testing randoms.
This change was not intended to stick here though, that was from early
workarounds.
I don't really want the random enforcement / support from the test framework
for a couple reasons, but this is simply something not removed - the problem
being if you used the mincluster and jetty with jetty.testMode=true and did not
launch things via carrot randomized runner, it will *sometimes* detect you dont
have a test randomized context for a thread and fail you - but we are not using
randomized runner or junit. Currently, I work around needing this workaround by
not using the jetty.testMode sys prop path and adding another sys prop hack atm
for where starting the mini cluster is a bit too tied into the test framework
and carrot random reqs.
Java 7 and up has essentially made Random obsolete, so there needs to be
some separation regardless, because we don't use carrot2 junit runners for
benchmarks, but it's also much preferable, faster, improved to avoid Random
entirely and use ThreadLocalRandom and SplittableRandom instead, so i try and
use them in the benchmarks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
