cpoerschke commented on a change in pull request #236:
URL: https://github.com/apache/solr/pull/236#discussion_r679338951
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/graph/ShortestPathStream.java
##########
@@ -433,7 +433,7 @@ public JoinRunner(List<String> nodes) {
StringBuffer nodeQuery = new StringBuffer();
for(String node : nodes) {
- nodeQuery.append(node).append(" ");
+ nodeQuery.append('"').append(node).append('"').append(" ");
Review comment:
> What happens if there are quotes in the id?
Good question! I'd briefly wondered about the backwards compatibility
aspects w.r.t. adding surrounding quotes in the code when the caller already
added them as a workaround, and then I had lost track of that.
One difference between the code adding surrounding quotes vs. the caller
adding them is that the code also adds them for interim nodes. I've amended the
test coverage to explore that further.
Also adjusted the code change to not add surrounding quotes if there are
some already but obviously quotes could also be in the middle of the id, say
`Alice ("Ally")` or `Robert ("Bob")` both of which also contain parentheses as
it happens, hmm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
