cpoerschke commented on a change in pull request #236:
URL: https://github.com/apache/solr/pull/236#discussion_r696931338
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/graph/ShortestPathStream.java
##########
@@ -252,6 +291,7 @@ public StreamExpressionParameter toExpression(StreamFactory
factory) throws IOEx
expression.addParameter(new StreamExpressionNamedParameter("from",
fromNode));
expression.addParameter(new StreamExpressionNamedParameter("to", toNode));
expression.addParameter(new StreamExpressionNamedParameter("edge",
fromField+"="+toField));
+ expression.addParameter(new StreamExpressionNamedParameter("legacyJoin",
Boolean.toString(legacyJoin)));
Review comment:
```suggestion
if (legacyJoin) expression.addParameter(new
StreamExpressionNamedParameter("legacyJoin", Boolean.toString(legacyJoin)));
```
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/io/graph/ShortestPathStream.java
##########
@@ -74,6 +74,33 @@
private int threads;
private SolrParams queryParams;
+ private boolean legacyJoin = false;
+
+ public ShortestPathStream(String zkHost,
Review comment:
```suggestion
@Deprecated
public ShortestPathStream(String zkHost,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]