[
https://issues.apache.org/jira/browse/SOLR-15209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399808#comment-17399808
]
Ilan Ginzburg commented on SOLR-15209:
--------------------------------------
Configuring legacy placement as a placement plugin increases complexity (code
changes, not only config changes) and in case something in the placement plugin
code line is broken, we might be unable to fall back to legacy (since it will
become a plugin as well).
If we could push a default configuration somehow, we could just push a config
for using the affinity placement factory (and let the user remove it if it
needs to). But we can't push a default config to ZK.
So nothing is really stopping us here, but the proposed solution doesn't feel
optimal.
FYI [~ab]
> Make the AffinityPlacementFactory the default placement plugin
> --------------------------------------------------------------
>
> Key: SOLR-15209
> URL: https://issues.apache.org/jira/browse/SOLR-15209
> Project: Solr
> Issue Type: Improvement
> Reporter: Andrzej Bialecki
> Assignee: Ilan Ginzburg
> Priority: Major
>
> Currently there's a lot of code in {{Assign}} dealing with the fact that we
> still support the old "legacy" replica assignment as well as the new
> plugin-based placement strategies.
> Furthermore, the "legacy" assignment is now the default even though it's
> neither robust nor optimal, except in the very simple and small clusters.
> Also, providing another plugin-based placement as the default impl. runs into
> a small complication - in the absence of any plugin config the code reverts
> to the "legacy".
> In order to promote the adoption of the new plugin-based placements we should
> make the {{AffinityPlacementFactory}} the new default placement strategy,
> selected when the explicit configuration is missing (and then create it as a
> default configuration in {{PlacementPluginFactoryLoader}}).
> I propose to re-package the "legacy" strategy as a {{PlacementPluginFactory}}
> so that it can be configured in the same way as other placement plugins.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
