epugh commented on a change in pull request #264:
URL: https://github.com/apache/solr/pull/264#discussion_r693485131
##########
File path:
solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java
##########
@@ -74,12 +75,12 @@ public void init(NamedList<?> args) {
args.remove("mutable");
managedSchemaResourceName = params.get(MANAGED_SCHEMA_RESOURCE_NAME,
DEFAULT_MANAGED_SCHEMA_RESOURCE_NAME);
args.remove(MANAGED_SCHEMA_RESOURCE_NAME);
- if (SCHEMA_DOT_XML.equals(managedSchemaResourceName)) {
+ if (SCHEMA_DOT_XML.equals(managedSchemaResourceName)) { // TODO Still
needed?
Review comment:
Reading through this again... I see that we have decided that
schema.xml can't be the managed schema file... Which I guess is fine, but if
you wanted it to be? Is tehre a use case for being able to override the
default managed schema name? I was wondering if it could just be hardcoded to
"managed-schema.xml" (wiht the legacy fall back to "managed-schema". Is there
ever a reason to have a different name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
