epugh commented on a change in pull request #264:
URL: https://github.com/apache/solr/pull/264#discussion_r693485382
##########
File path: solr/core/src/java/org/apache/solr/schema/ManagedIndexSchema.java
##########
@@ -111,13 +111,41 @@
this.schemaUpdateLock = schemaUpdateLock;
}
+ /**
+ * Lookup the path to the managed schema, dealing with falling back to the
+ * legacy managed-schema file, instead of the expected managed-schema.xml
file.
+ *
+ * This method is duplicated in ManagedIndexSchemaFactory.
+ * @see
org.apache.solr.schema.ManagedIndexSchemaFactory#lookupManagedSchemaPath
+ */
+ public String lookupManagedSchemaPath() {
Review comment:
Yeah, I definitly saw this as a code smell, and yeah, I couldn't quite
figure out how to make sure `managedSchemaResourceName` was ever changed from
the default to `managed-schema.xml` to the `managed-schema` at the right time.
I've also experimented with moving this whole method over to
ZkSolrResourceLoader, with the idea that it is the right class to do the fall
back lookup....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
