gerlowskija commented on a change in pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#discussion_r694263848
##########
File path: controllers/util/backup_util.go
##########
@@ -440,3 +483,13 @@ func RunExecForPod(podName string, namespace string,
command []string, config re
return nil
}
+
+// TODO Is the Mozilla license on hashicorp's go-version lib we're using here
acceptable by Apache? Is there a better option?
+func SupportsGcsBackups(versionStr string) (bool, error) {
Review comment:
I'd need to double-check the codepath, but this doesn't use the image
metadata - it gets the data from Solr itself (using `/solr/admin/info/system`
if I remember right).
Does that address your concern about brittle-ness? Or would you still
prefer this be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
