gerlowskija commented on a change in pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#discussion_r706189501
##########
File path: controllers/solrcloud_controller.go
##########
@@ -699,6 +695,41 @@ func reconcileCloudStatus(r *SolrCloudReconciler,
solrCloud *solr.SolrCloud, log
return outOfDatePods, outOfDatePodsNotStarted,
availableUpdatedPodCount, nil
}
+func isPodReadyForBackup(pod corev1.Pod, backupOptions
*solr.SolrBackupRestoreOptions) bool {
Review comment:
As written, this method checks if a single pod is ready to handle a
backup for any/all of its repositories. This information gets surfaced to
consumers under the `backupRestoreReady` boolean field of `SolrCloudStatus`.
We can definitely change it to take a specific repository, but since this
call isn't happening at backup-time, we'd still have to call it in a loop for
each repository defined on the solrcloud instance and then "AND" each of those
results together to get the single `backupRestoreReady` value. So I'm not
really sure that gets us anything?
Unless you're thinking that we'd change SolrCloudStatus to include a
distinct "backupReadiness" status for each repository so that we could check
the one we care about at "backup time". I'd be OK with that if that's what
you're suggesting, just wanted to double check we're envisioning the same thing
here as it's a broader change than just the function-signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
