dsmiley commented on a change in pull request #329:
URL: https://github.com/apache/solr/pull/329#discussion_r735199467
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
##########
@@ -1265,10 +1265,12 @@ public void processGetUpdates(ResponseBuilder rb)
throws IOException
// TODO: get this from cache instead of rebuilding?
try (UpdateLog.RecentUpdates recentUpdates = ulog.getRecentUpdates()) {
+ Set<Long> updateVersions = new HashSet<>();
Review comment:
I was going to suggest `org.apache.solr.util.LongSet` but I suppose we
can assume this set won't accumulate more than a handful at most so whatever.
A comment "should be small" or something would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
