cpoerschke commented on a change in pull request #329:
URL: https://github.com/apache/solr/pull/329#discussion_r736454613
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java
##########
@@ -1265,10 +1265,12 @@ public void processGetUpdates(ResponseBuilder rb)
throws IOException
// TODO: get this from cache instead of rebuilding?
try (UpdateLog.RecentUpdates recentUpdates = ulog.getRecentUpdates()) {
+ Set<Long> updateVersions = new HashSet<>();
Review comment:
`LongSet.add` currently does not return a `boolean` but that could be
added -- #370 -- and then yes we could use `LongSet` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
