thelabdude commented on a change in pull request #460:
URL: https://github.com/apache/solr/pull/460#discussion_r771744339
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
##########
@@ -976,9 +975,6 @@ private void loadClusterProperties() {
this.clusterProperties =
ClusterProperties.convertCollectionDefaultsToNestedFormat(properties);
log.debug("Loaded cluster properties: {}", this.clusterProperties);
- // Make the urlScheme globally accessible
-
UrlScheme.INSTANCE.setUrlScheme(getClusterProperty(ZkStateReader.URL_SCHEME,
HTTP));
Review comment:
We don't want to set the Singleton `urlScheme` in the `ZkStateReader`
since that runs on the client side too, which would force all clients to use
the same scheme if multiple are talking to different clusters (or it might
flip-flop around too, which would be really bad). It's best for the "client"
side to get back whatever is stored from the server, which is why we have to
store `base_url` in the replica state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
