thelabdude commented on a change in pull request #460:
URL: https://github.com/apache/solr/pull/460#discussion_r786990164
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java
##########
@@ -469,6 +469,7 @@ public boolean split(ClusterState clusterState, ZkNodeProps
message, NamedList<O
ZkStateReader.REPLICA_TYPE, replicaPosition.type.name(),
ZkStateReader.STATE_PROP, Replica.State.DOWN.toString(),
ZkStateReader.NODE_NAME_PROP, subShardNodeName,
+ ZkStateReader.BASE_URL_PROP,
zkStateReader.getBaseUrlForNodeName(subShardNodeName),
Review comment:
Good point! All the code in `core` should use `UrlScheme.INSTANCE` and
all the code in `solrj` should use the `ZkStateReader#getBaseUrlForNodeName`.
Will update across the codebase to make this consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
