HoustonPutman opened a new pull request #498: URL: https://github.com/apache/solr/pull/498
https://issues.apache.org/jira/browse/SOLR-15891 This removes the bloat in the first non-header docker layer, specifically this line: ``` find /opt/solr/ -type f -print0 | xargs -0 chmod 0644; \ ``` That line increased the size of that docker layer to the complete size of the solr installation, meaning that two layers (in both local and official) were the full size of the solr installation. By moving the 0644 chmod to the COPY and download sections, in local and official, the only thing we have to do in the referenced layer is give executables and directories the correct permissions, which in practice takes `250kB` instead of `200mB`. This achieves what we want. One caveat is that `COPY --chmod` requires buildkit enabled, and Docker v20 installed. I think this is fine given this is a new offering, so we can assume users are using new Docker versions. (much better than having the docker image be 1.5-2x the size) Some other small changes made: - The tests now re-run when the `shared.sh` file is changed - The test official image is tagged when it is built. We can change this in the future if we want to. (Maybe we re-think this in the future, and have a flag for the docker build to be "official" or "local", and keep the same commands (disabling push for "official".)) - I fixed the labels for the docker image - The test directories that use `setfacl` on linux, now use `chmod a+rwx` if `setfacl` is not available. This is unfortunate, but there really is no other work around if we want the tests to run on Macs. Willing to have discussion here if y'all don't think this is acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
