janhoy commented on a change in pull request #498:
URL: https://github.com/apache/solr/pull/498#discussion_r779194380
##########
File path: solr/docker/templates/Dockerfile.official.header.template
##########
@@ -90,5 +90,6 @@ RUN set -ex; \
fi; \
{ command -v gpgconf; gpgconf --kill all || :; }; \
rm -r "$GNUPGHOME"; \
- tar -C /opt --extract --file "/opt/solr-$SOLR_VERSION.tgz";
+ tar -C /opt --extract --preserve-permissions --file
"/opt/solr-$SOLR_VERSION.tgz"; \
+ find "/opt/solr-$SOLR_VERSION/" -type f -print0 | xargs -0 chmod 0644;
Review comment:
Speaking of saving space, could we uninstall gpg at the end of this
`RUN` command? I.e. `apt-get --purge remove gpg && rm -rf
/var/lib/apt/lists/*;` at the end?
##########
File path: solr/docker/tests/shared.sh
##########
@@ -113,8 +113,8 @@ function prepare_dir_to_mount {
# If you can't use setfacl (eg on macOS), you'll have to chown the directory
to 8983, or apply world
# write permissions.
if ! command -v setfacl &> /dev/null; then
- echo "Test case requires the 'setfacl' command but it can not be found"
- exit 1
+ echo "Test case requires the 'setfacl' command but it can not be found.
Will set the directory to have read/write all permissions"
+ chmod a+rwx "$folder"
Review comment:
Good solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
