janhoy commented on a change in pull request #518:
URL: https://github.com/apache/solr/pull/518#discussion_r782898576
##########
File path: solr/core/build.gradle
##########
@@ -115,9 +115,6 @@ dependencies {
testImplementation 'org.slf4j:jcl-over-slf4j'
- // JWT Auth plugin
- api 'org.bitbucket.b_c:jose4j'
Review comment:
The jose lib was defined as `api` in solr-core. When I moved it into the
contrib (as implementation), suddenly all contribs complained they could not
find `slf4j`. I considered changing `org.slf4j:slf4j-api` to `api` scope in
solr-core, to give all contribs depending on solr-core access to the logger.
But then I instead added `slf4j-api` to all of them explicitly. Any preference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
