madrob commented on a change in pull request #518:
URL: https://github.com/apache/solr/pull/518#discussion_r783218761
##########
File path:
solr/contrib/jwt-auth/src/java/org/apache/solr/security/JWTAuthPlugin.java
##########
@@ -104,15 +102,31 @@
@Deprecated(since = "9.0") // Remove in 10.0
private static final String PARAM_ALG_WHITELIST = "algWhitelist";
- private static final Set<String> PROPS = ImmutableSet.of(PARAM_BLOCK_UNKNOWN,
- PARAM_PRINCIPAL_CLAIM, PARAM_REQUIRE_EXPIRATIONTIME, PARAM_ALG_ALLOWLIST,
- PARAM_JWK_CACHE_DURATION, PARAM_CLAIMS_MATCH, PARAM_SCOPE, PARAM_REALM,
PARAM_ROLES_CLAIM,
- PARAM_ADMINUI_SCOPE, PARAM_REDIRECT_URIS, PARAM_REQUIRE_ISSUER,
PARAM_ISSUERS,
- PARAM_TRUSTED_CERTS_FILE, PARAM_TRUSTED_CERTS,
- // These keys are supported for now to enable PRIMARY issuer config
through top-level keys
- JWTIssuerConfig.PARAM_JWKS_URL, JWTIssuerConfig.PARAM_JWK,
JWTIssuerConfig.PARAM_ISSUER,
- JWTIssuerConfig.PARAM_CLIENT_ID, JWTIssuerConfig.PARAM_WELL_KNOWN_URL,
JWTIssuerConfig.PARAM_AUDIENCE,
- JWTIssuerConfig.PARAM_AUTHORIZATION_ENDPOINT);
+ private static final ImmutableSet<String> PROPS =
Review comment:
Why did this type change from Set?
##########
File path:
solr/contrib/jwt-auth/src/java/org/apache/solr/security/JWTIssuerConfig.java
##########
@@ -408,8 +428,8 @@ private HttpsJwks create(String url) {
}
/**
- * Config object for a OpenId Connect well-known config
- * Typically exposed through /.well-known/openid-configuration endpoint
+ * Config object for a OpenId Connect well-known config Typically exposed
through
Review comment:
Include an explicit `<p>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
