janhoy commented on a change in pull request #526:
URL: https://github.com/apache/solr/pull/526#discussion_r785185023
##########
File path: solr/solr-ref-guide/src/jdbc-dbvisualizer.adoc
##########
@@ -22,8 +22,8 @@ For DbVisualizer, you will need to create a new driver for
Solr using the DbVisu
This will add several SolrJ client .jars to the DbVisualizer classpath.
The files required are:
-* all .jars found in `$SOLR_HOME/dist/solrj-lib`
-* the SolrJ .jar found at `$SOLR_HOME/dist/solr-solrj-<version>.jar`
+* all .jars found in `$SOLR_HOME/server/solr-webapp/webapp/WEB-INF/lib/\*` and
`$SOLR_HOME/server/lib/ext/*`
Review comment:
I'm still not convinced about `server/lib/ext/*`. They are logging jars
and slf4j bindings, while the `slf4j-api` is in solr-core.jar. Does it even
make sense for JDBC driver to log anything anywhere? Where would that log end
up? If you do NOT include those jars, then the slf4j-api code would simply
output to sterr a warning that no logger binding was found for slf4j, so no
logging will be done. Which is probably ok for a jdbc driver?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
