janhoy commented on a change in pull request #526:
URL: https://github.com/apache/solr/pull/526#discussion_r785236069
##########
File path: solr/solr-ref-guide/src/jdbc-dbvisualizer.adoc
##########
@@ -22,8 +22,8 @@ For DbVisualizer, you will need to create a new driver for
Solr using the DbVisu
This will add several SolrJ client .jars to the DbVisualizer classpath.
The files required are:
-* all .jars found in `$SOLR_HOME/dist/solrj-lib`
-* the SolrJ .jar found at `$SOLR_HOME/dist/solr-solrj-<version>.jar`
+* all .jars found in `$SOLR_HOME/server/solr-webapp/webapp/WEB-INF/lib/\*` and
`$SOLR_HOME/server/lib/ext/*`
Review comment:
+1 to a fat jdbc jar. But I'm reluctant to adding it to the fat tgz
which will be even fatter.
Or could be make the build only push the fat-jar to maven, without including
it in the tgz? Then the docs could tell people that a fat jdbc jar exists, and
we could include its SHA-sum in the tgz to testify to its validity?
This is a good example of a jar that is never needed by Solr server side, so
making it a plugin package won't make sense. Maven is the way to go, and, if
required, upload the jar as a separate jar or tgz artifact in the release repo.
When we split solrj into even more specialized jars, perhaps we'd also want
to provide a single `solrj-all.jar` for convenience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
