janhoy commented on a change in pull request #536:
URL: https://github.com/apache/solr/pull/536#discussion_r786644168



##########
File path: solr/server/resources/log4j2.xml
##########
@@ -39,9 +39,9 @@
       </PatternLayout>
       <Policies>
         <OnStartupTriggeringPolicy />
-        <SizeBasedTriggeringPolicy size="32 MB"/>
+        <SizeBasedTriggeringPolicy size="${sys:solr.log.maxsize:-32 MB}"/>
       </Policies>
-      <DefaultRolloverStrategy max="10"/>
+      <DefaultRolloverStrategy max="${sys:solr.log.rolloverdays:-10}"/>

Review comment:
       While working with rollover configuration for requestlogs, I also 
thought I'd make the size and number of files for the ordinary solr.log 
configurable. New sys.props: `-Dsolr.log.rolloversize` and 
`-Dsolr.log.filestokeep`. They still default to `32Mb` and `10` respectively. 
This also needs testing and documenting in refguide.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to