janhoy commented on a change in pull request #536:
URL: https://github.com/apache/solr/pull/536#discussion_r786699172



##########
File path: solr/server/resources/log4j2.xml
##########
@@ -39,9 +39,9 @@
       </PatternLayout>
       <Policies>
         <OnStartupTriggeringPolicy />
-        <SizeBasedTriggeringPolicy size="32 MB"/>
+        <SizeBasedTriggeringPolicy size="${sys:solr.log.rolloversize:-32 MB}"/>
       </Policies>
-      <DefaultRolloverStrategy max="10"/>
+      <DefaultRolloverStrategy max="${sys:solr.log.filestokeep:-10}"/>

Review comment:
       I think I'll separate out this (unrelated) change into its own PR for 
better clarity.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to