janhoy commented on a change in pull request #542:
URL: https://github.com/apache/solr/pull/542#discussion_r787657917
##########
File path: solr/core/src/java/org/apache/solr/util/StartupLoggingUtils.java
##########
@@ -187,4 +187,19 @@ public static String getLogLevelString() {
else if (rootLogger.isErrorEnabled()) return "ERROR";
else return "INFO";
}
+
+ /**
+ * Check whether Jetty requestlogging is enabled and log info about it
+ */
+ public static void checkRequestLogging() {
+ boolean requestLogEnabled = System.getProperty("sun.java.command",
"").contains("module=requestlog");
Review comment:
Found no smarter way to check whether that module is active. There is
probably some static Jetty class method that would do the same and be more
rubust (such as when Oracle changes the name of `sun.java.command` property..?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
