janhoy commented on a change in pull request #542:
URL: https://github.com/apache/solr/pull/542#discussion_r787658907



##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -730,6 +731,8 @@ public void load() {
 
     logging = LogWatcher.newRegisteredLogWatcher(cfg.getLogWatcherConfig(), 
loader);
 
+    StartupLoggingUtils.checkRequestLogging();

Review comment:
       I could have logged this already in `CoreContainerProvider` but I wanted 
to have the warn included in the Admin UI, and thus had to do it after 
initializing the `LogWatcher`. I wonder if we can initialize LogWatcher earlier 
on?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to