[
https://issues.apache.org/jira/browse/SOLR-15922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479344#comment-17479344
]
Jan Høydahl commented on SOLR-15922:
------------------------------------
Hoss suggested in SOLR-13786 that it could be due to the metric containing
white-space and I did a test on JDK 11 and JDK 17 respectively:
{code:java}
JDK 11
"solr.jvm":{
"buffers.direct.Count":65,
"buffers.direct.MemoryUsed":2042105,
"buffers.direct.TotalCapacity":2042105,
"buffers.mapped.Count":0,
"buffers.mapped.MemoryUsed":0,
"buffers.mapped.TotalCapacity":0,
JDK 17
"solr.jvm":{
"buffers.direct.Count":72,
"buffers.direct.MemoryUsed":2061164,
"buffers.direct.TotalCapacity":2061164,
"buffers.mapped - 'non-volatile memory'.Count":0,
"buffers.mapped - 'non-volatile memory'.MemoryUsed":0,
"buffers.mapped - 'non-volatile memory'.TotalCapacity":0,
"buffers.mapped.Count":0,
"buffers.mapped.MemoryUsed":0,
"buffers.mapped.TotalCapacity":0, {code}
And in {{SolrExporterTestBase}} we split each line on space: {{String[] parts =
currentLine.split(" ");}}, and fail if >2.
> SolrExporterIntegrationTest fails on Java 17
> --------------------------------------------
>
> Key: SOLR-15922
> URL: https://issues.apache.org/jira/browse/SOLR-15922
> Project: Solr
> Issue Type: Task
> Components: contrib - prometheus-exporter, Tests
> Reporter: Mike Drob
> Priority: Major
>
> {{gradlew test --tests SolrExporterIntegrationTest.solrExporterDurationMetric
> -Dtests.seed=2604C3F34A214F5C}}
> This passes for me on Java 11 but fails consistently with Java 17
> {noformat}
> > java.lang.AssertionError: Metric must have name and value:
> solr_metrics_jvm_buffers{pool="mapped - 'non-volatile
> memory'",base_url="http://127.0.0.1:57657/solr",} 0.0 expected:<2> but was:<5>
> > at
> __randomizedtesting.SeedInfo.seed([2604C3F34A214F5C:9D01B8BFD4BC7AAF]:0)
> > at org.junit.Assert.fail(Assert.java:89)
> > at org.junit.Assert.failNotEquals(Assert.java:835)
> > at org.junit.Assert.assertEquals(Assert.java:647)
> > at
> org.apache.solr.prometheus.exporter.SolrExporterTestBase.getAllMetrics(SolrExporterTestBase.java:110)
> > at
> org.apache.solr.prometheus.exporter.SolrExporterTestBase.startMetricsExporterWithConfiguration(SolrExporterTestBase.java:79)
> > at
> org.apache.solr.prometheus.exporter.SolrExporterIntegrationTest.setUp(SolrExporterIntegrationTest.java:34)
> {noformat}
> Looks like some of the formatting changed between internals?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
