[
https://issues.apache.org/jira/browse/SOLR-15922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479459#comment-17479459
]
Jan Høydahl commented on SOLR-15922:
------------------------------------
Yes, it assumed the prometheus lines was only allowed to contain one single
space, to separate the key and the float value. And with Java 11 that was true
for Solr. But it is not a requirement. So just a test issue with string parsing.
> SolrExporterIntegrationTest fails on Java 17
> --------------------------------------------
>
> Key: SOLR-15922
> URL: https://issues.apache.org/jira/browse/SOLR-15922
> Project: Solr
> Issue Type: Task
> Components: contrib - prometheus-exporter, Tests
> Reporter: Mike Drob
> Assignee: Jan Høydahl
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {{gradlew test --tests SolrExporterIntegrationTest.solrExporterDurationMetric
> -Dtests.seed=2604C3F34A214F5C}}
> This passes for me on Java 11 but fails consistently with Java 17
> {noformat}
> > java.lang.AssertionError: Metric must have name and value:
> solr_metrics_jvm_buffers{pool="mapped - 'non-volatile
> memory'",base_url="http://127.0.0.1:57657/solr",} 0.0 expected:<2> but was:<5>
> > at
> __randomizedtesting.SeedInfo.seed([2604C3F34A214F5C:9D01B8BFD4BC7AAF]:0)
> > at org.junit.Assert.fail(Assert.java:89)
> > at org.junit.Assert.failNotEquals(Assert.java:835)
> > at org.junit.Assert.assertEquals(Assert.java:647)
> > at
> org.apache.solr.prometheus.exporter.SolrExporterTestBase.getAllMetrics(SolrExporterTestBase.java:110)
> > at
> org.apache.solr.prometheus.exporter.SolrExporterTestBase.startMetricsExporterWithConfiguration(SolrExporterTestBase.java:79)
> > at
> org.apache.solr.prometheus.exporter.SolrExporterIntegrationTest.setUp(SolrExporterIntegrationTest.java:34)
> {noformat}
> Looks like some of the formatting changed between internals?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
