dsmiley commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r793013536
##########
File path: solr/CHANGES.txt
##########
@@ -256,9 +256,8 @@ when told to. The admin UI now tells it to. (Nazerke
Seidan, David Smiley)
* SOLR-15209: The old LegacyAssignStrategy has been refactored into the
SimplePlacementPlugin. This is still the default
placement policy for Solr. (Houston Putman, Ilan Ginzburg)
-* SOLR-15257: Add DocSetQuery in lieu of DocSet.getTopFilter. This issue led
to removing
- Filter.java and eliminating all dependencies on its main method getDocIdSet.
With Filter deleted ,
- and replaced with Lucene's Query.java, the changes might spark some
performance optimizations (Collins Abanda, Mike Drob, Tim Potter)
+* SOLR-12336: Remove Filter and SolrFilter, replaced by DocSetQuery which is a
Query
Review comment:
Instead, I'd prefer two JIRAs to reference in the CHANGES.txt. One is
DocSet.getTopFilter being replaced by DocSet.makeQuery. This is one discrete
change, even though you're choosing to do so in one commit/PR including other
stuff. The other is that Filter no longer has a need to exist due to multiple
JIRA issues, implemented by a number of issues. Perhaps reference nobody in
particular there, or reference all of us at your discretion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
