dsmiley commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r793016743
##########
File path: solr/core/src/java/org/apache/solr/search/SolrConstantScoreQuery.java
##########
@@ -41,17 +41,20 @@
* Experimental and subject to change.
*/
public class SolrConstantScoreQuery extends Query implements ExtendedQuery {
- private final Filter filter;
Review comment:
Justification: SolrConstantScoreQuery's purpose *was* to bridge the
Filter API to a Query API. It became instant tech-debt the moment Filter
subclassed Query (years ago). Now with Filter going away, SCSQ has even less
reason to exist -- it's basically a Lucene ConstantScoreQuery + Solr
ExtendedQuery which we don't need. Anyone who wants such a thing can simply do
`new WrappedQuery(someOtherQuery)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
