magibney commented on a change in pull request #592:
URL: https://github.com/apache/solr/pull/592#discussion_r801240516
##########
File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
##########
@@ -2281,6 +2455,11 @@ public void initializeMetrics(SolrMetricsContext
parentContext, String scope) {
parentContext.gauge(() -> openTime, true, "openedAt",
Category.SEARCHER.toString(), scope);
parentContext.gauge(() -> warmupTime, true, "warmupTime",
Category.SEARCHER.toString(), scope);
parentContext.gauge(() -> registerTime, true, "registeredAt",
Category.SEARCHER.toString(), scope);
+ parentContext.gauge(fullSortCount::get, true, "fullSortCount",
Category.SEARCHER.toString(), scope);
+ parentContext.gauge(skipSortCount::get, true, "skipSortCount",
Category.SEARCHER.toString(), scope);
+ parentContext.gauge(matchAllDocsCacheConsultationCount::get, true,
"matchAllDocsCacheConsultationCount", Category.SEARCHER.toString(), scope);
+ parentContext.gauge(matchAllDocsCacheHitCount::get, true,
"matchAllDocsCacheHitCount", Category.SEARCHER.toString(), scope);
+ parentContext.gauge(matchAllDocsCacheComputationTracker::get, true,
"matchAllDocsCacheComputationTracker", Category.SEARCHER.toString(), scope);
Review comment:
Yes, I went the 1-element cache route and I like it! Way easier and
cleaner, I think. I did introduce a couple of additional metrics, including
`asyncHits` directly in CaffeineCache, to track the impact of "async" operation
(see SOLR-15555). Basically the point of all of these metrics were to
"whitebox"-test assumptions about how caching/sort optimizations work. None of
them are strictly necessary, but I think they could be useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
