magibney commented on a change in pull request #592:
URL: https://github.com/apache/solr/pull/592#discussion_r802960783



##########
File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
##########
@@ -1299,6 +1385,47 @@ public DocList getDocList(Query query, List<Query> 
filterList, Sort lsort, int o
   public static final int GET_DOCLIST = 0x02; // get the documents actually 
returned in a response
   public static final int GET_SCORES = 0x01;
 
+  private static boolean isConstantScoreQuery(Query q) {

Review comment:
       :+1: 87c9a13871787753947375d23dbb8aa855b17b78
   
   I tried checking here that this wasn't going to magically mess something up 
downstream (e.g., via some hard check for `instanceof ConstantScoreQuery`). 
Looks safe, and if you feel confident in this change that works for me. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to