cpoerschke commented on a change in pull request #595:
URL: https://github.com/apache/solr/pull/595#discussion_r801624967
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/BackupCmd.java
##########
@@ -138,6 +138,15 @@ public void call(ClusterState state, ZkNodeProps message,
NamedList<Object> resu
backupMgr.writeBackupProperties(backupProperties);
+ // It can't be done within aggregateResults call
+ // since endTime is filled later
+ if(backupProperties != null) {
Review comment:
Interesting. But even with the existing `copyIndexFiles` logic, could we
not simplify here:
```suggestion
// It can't be done within aggregateResults call
// since endTime is filled later
{
```
because earlier at line 89 we always have
```
BackupProperties backupProperties = BackupProperties.create(backupName,
collectionName,
extCollectionName, configName);
```
i.e. `backupProperties` never is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
