ijioio commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036372884
Hi, @cpoerschke ! Thank you for the comments!
> Could it also be confusing for users to have both indexFileCount and
uploadedIndexFileCount values instead of the one fileCount value? I'm curious
though why it's called fileCount and not indexFileCount in the snapshot i.e.
would a snapshot after an incremental backup not have the same count for both
(assuming no changes in the interim)?
Yes, I agree! After I have pushed changes I thought the same :) We can
expose only `fileCount` single field for snapshot backups. It is not a problem.
Even better, we can use `indexFileCount` field to exactly express the nature of
the content. This way aggregated result for incremental backups will contain
both `indexFileCount` and `uploadedIndexFileCount`, while snapshot backups will
only contain `indexFileCount` field.
> Hmm, subjectively no backup id seems clearer than a backup id of -1 value,
but that's just me.
OK. We can exclude it. Value `-1` is just a value that is assigned for non
incremental backups within `BackupManager.forBackup` call:
```java
BackupManager backupMgr = (incremental) ?
BackupManager.forIncrementalBackup(repository,
ccc.getZkStateReader(), backupUri) :
BackupManager.forBackup(repository, ccc.getZkStateReader(),
backupUri);
```
> Not connected to any specific response element(s), do we know what
backwards compatibility considerations apply here and/or any thoughts on how to
communicate changes to users? E.g. additional elements likely would not break
existing usage of the JSON but renaming or removal of existing elements might.
You are absolutely right! The most pleasant thing here we are not going to
change any shard's responses format. We are going to extend aggregated result
content for snapshot backups only. Initially it is quite poor:
```json
"response": {
"collection": "techproducts",
"numShards": 2,
"endTime": "2022-02-09T07:25:52.879269500Z"
}
```
so we can extend it any way we want without worrying about breaking some
backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
