ijioio commented on pull request #595:
URL: https://github.com/apache/solr/pull/595#issuecomment-1036498290
> I see one in deleteNamedSnapshot() as well.
Updated
> Understood, but I think the best user experience is that people can expect
the same field names for single-shard vs multi-shard. So might as well do it in
this PR 🙂
Agree! I've added duplicate fields to shard response:
- `indexFileCount` for `fileCount`
- `endTime` for `snapshotCompletedAt`
```java
details.add("fileCount", files.size()); // TODO: for removal, replaced with
indexFileCount
details.add("indexFileCount", files.size());
...
details.add("snapshotCompletedAt", Instant.now().toString()); // TODO: for
removal, replaced with endTime
details.add("endTime", Instant.now().toString());
```
Here is an example of shard responses:
For incremental:
```json
"response": {
"startTime": "2022-02-11T18:07:34.306028400Z",
"indexFileCount": 21,
"uploadedIndexFileCount": 21,
"indexSizeMB": 0.006,
"uploadedIndexFileMB": 0.006,
"shard": "shard1",
"endTime": "2022-02-11T18:07:34.350180600Z",
"shardBackupId": "md_shard1_0"
}
```
For snapshot:
```json
"response": {
"startTime": "2022-02-11T18:08:31.405757700Z",
"fileCount": 21,
"indexFileCount": 21,
"status": "success",
"snapshotCompletedAt": "2022-02-11T18:08:31.437883800Z",
"endTime": "2022-02-11T18:08:31.437883800Z",
"snapshotName": "shard1",
"directoryName": "snapshot.shard1"
}
```
@cpoerschke how you think, is it OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
