risdenk commented on a change in pull request #621:
URL: https://github.com/apache/solr/pull/621#discussion_r806345824
##########
File path: solr/modules/extraction/build.gradle
##########
@@ -26,55 +26,18 @@ dependencies {
implementation 'org.apache.lucene:lucene-core'
implementation 'org.slf4j:slf4j-api'
- // We export tika because other modules depend on it (and its submodules)
Review comment:
So I'm on the fence about this with Tika. Since `tika-core` is NOT the
only thing needed to do language detection as far as I know. It would be a lot
more duplication of jars just to get language detection working. (I'm not even
100% sure that all the tika parsers in the extraction module are right for Tika
to do language detection with the langid module). I think leaving it like this
is going to be the most expected for now. I do think this needs more thought
separately though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
