risdenk commented on a change in pull request #621:
URL: https://github.com/apache/solr/pull/621#discussion_r806848496
##########
File path: solr/modules/extraction/build.gradle
##########
@@ -26,55 +26,18 @@ dependencies {
implementation 'org.apache.lucene:lucene-core'
implementation 'org.slf4j:slf4j-api'
- // We export tika because other modules depend on it (and its submodules)
Review comment:
There is an entire `tika-langdetect` dependency -
https://search.maven.org/artifact/org.apache.tika/tika-langdetect/1.28.1/bundle
or https://mvnrepository.com/artifact/org.apache.tika/tika-langdetect/1.28.1. I
played with `langid` years ago and remember having to add jars to get it to
actually work. I could add `tika-langdetect` as `runtimeOnly` in the `langid`
module, but that adds more jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
