magibney commented on a change in pull request #592:
URL: https://github.com/apache/solr/pull/592#discussion_r808356737
##########
File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
##########
@@ -119,10 +128,18 @@
private final int queryResultMaxDocsCached;
private final boolean useFilterForSortedQuery;
+ /**
+ * Special-case cache to handle the lazy-init of {@link #liveDocs}.
+ */
+ private final SolrCache<MatchAllDocsQuery,BitDocSet> liveDocsCache;
Review comment:
Yeah; it started out as something ostensibly "simpler" like that, but
once you layer in the metrics (mainly to support tests) it becomes less simple.
I wonder how succinct it could be, maybe worth a shot.
I'll mull this; if it's something you feel (somewhat) strongly about I'll
take a crack at it.
EDIT: nevermind, done in 14f7ac5434626e5d3a068b8c2489b0d604171daa -- were
you thinking something along these lines?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
