magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808369044
########## File path: solr/core/src/test/org/apache/solr/search/TestMainQueryCaching.java ########## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.search; + +import java.util.Map; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Future; +import java.util.concurrent.TimeUnit; + +import org.apache.solr.SolrTestCaseJ4; +import org.apache.solr.common.util.ExecutorUtil; +import org.apache.solr.common.util.SolrNamedThreadFactory; +import org.apache.solr.core.SolrCore; +import org.apache.solr.metrics.MetricsMap; +import org.apache.solr.metrics.SolrMetricManager; +import org.junit.AfterClass; +import org.junit.Before; +import org.junit.BeforeClass; +import org.junit.Test; + +import static org.apache.solr.common.util.Utils.fromJSONString; + +/** + * Verify caching interactions between main query and filterCache + */ +public class TestMainQueryCaching extends SolrTestCaseJ4 { + + private static final int MOST_DOCS = 100; + private static final int ALL_DOCS = MOST_DOCS + 1; + private static final String TEST_UFFSQ_PROPNAME = "solr.test.useFilterForSortedQuery"; + static String RESTORE_UFFSQ_PROP; + static boolean USE_FILTER_FOR_SORTED_QUERY; + + @BeforeClass + public static void beforeClass() throws Exception { + // TODO: figure out why the line below (accepting this property as overridden on test invocation) isn't working + // as expected. Review comment: The goal was to allow explicitly specifying `-Psolr.test.useFilterForSortedQuery=true|false` on the command line, but it looks like the system properties are filtered by gradle maybe (?) ... in any event when I tried to set this property explicitly it didn't get picked up in the actual test. If there's a quick answer, I'd be curious to know; but either way I agree with your implicit suggestion that leaving this as a TODO comment doesn't make sense ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
