dsmiley commented on pull request #657: URL: https://github.com/apache/solr/pull/657#issuecomment-1062197347
I think it's ready finally. Please check out the ref guide explanation that I just pushed. I think the outdated MetricsQueryTemplateTest ought to be replaced with a very different integration test that is more of a sanity check that certain metrics we expect to see are present. Such a test could be done via docker and it'd thus offer more/better test coverage that other aspects are working too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
