HoustonPutman commented on pull request #657: URL: https://github.com/apache/solr/pull/657#issuecomment-1064368522
Ok found an issue, the `core-query` template isn't the only affected template for prometheus. `core` has metrics that contain `[shard]` as well, including (but not limited to): - `solr_metrics_core_errors_total` - `solr_metrics_core_requests_total ` - `solr_metrics_core_timeouts_total` It was an easy fix, adding the same code from the `core-query` template, but it also means that the `internal=false` tag will be added for other handlers that may be used internally, we just don't include the tag for it. Personally I think that's fine and it can be seen as a possible improvement for the future. (I don't think the graphana dashboard is necessarily impacted by this. We could certainly add the tag filter for these metrics, but I don't think its necessary for this PR) I'll go ahead and push the fix and let you take a look @dsmiley. Otherwise I'm good with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
