dsmiley commented on a change in pull request #708:
URL: https://github.com/apache/solr/pull/708#discussion_r824374698
##########
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
##########
@@ -221,6 +223,19 @@
// only kept to identify if the cleaner has already been started.
private Future<?> collectionPropsCacheCleaner;
+ private static BaseCloudSolrClient client;
Review comment:
Important: this addition is definitely not cool. The refactoring here
shouldn't be adding state (fields on classes) to anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
