janhoy commented on a change in pull request #708:
URL: https://github.com/apache/solr/pull/708#discussion_r824864772
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ZkClientClusterStateProvider.java
##########
@@ -215,6 +215,11 @@ static String buildZkHostString(Collection<String>
zkHosts, String chroot) {
return zkHostString;
}
+ @Override
+ public String getQuorumHosts() {
+ return zkStateReader.getZkClient().getZkServerAddress();
Review comment:
Even when I replace `zkStateReader` with `getZkStateReader()`, some
tests fail.
I believe the `CloudHttp2SolrClientBuilderTest` was designed to simply test
that the (dummy) ZK_HOST provided is being set, but the way the test was
changed in this PR makes it want to connect to that ZK, which of course fails...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
