magibney commented on code in PR #828:
URL: https://github.com/apache/solr/pull/828#discussion_r862154070
##########
solr/core/src/java/org/apache/solr/search/join/ChildFieldValueSourceParser.java:
##########
@@ -128,16 +97,7 @@ public String toString() {
public SortField getSortField(boolean reverse) {
final Type type = childField.getSortField(reverse).getType();
return new ToParentBlockJoinSortField(
- childField.getName(), type, reverse, parentFilter, childFilter) {
Review Comment:
AFAICT these lines existed to compensate for the fact that SchemaField was
not carried along to support marshalling SortFields. This PR introduces an
alternative approach that makes this no longer necessary (and works equally
well in distrib/standalone).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
