magibney commented on PR #828: URL: https://github.com/apache/solr/pull/828#issuecomment-1117981849
Cleaned this up quite a bit. The essence of what's happening here is pretty straightforward: 1. ValueSources need to supply their own SortField, but in Solr they need to supply a SortField that is aware of missing values, etc., so we wrap Lucene ValueSource impls to delegate getSortField() to the Solr FieldType. 2. We leverage `FieldCacheSource` (which I finally now think I understand its purpose) to determine when/how to do specialized marshalling/unmarshalling of sort values. That's it! I plan (pending feedback/approval) to add some javadocs to Lucene `FieldCacheSource` clarifying its uses, and change Lucene `JoinDocFreqValueSource` so that it no longer extends `FieldCacheSource` (I think it never should have). Assuming that goes as I anticipate, we'll be able to remove the special-case for `JoinDocFreqValueSource` in `SortSpecParsing`. If it doesn't go as I anticipate, will re-evaluate and decide how to proceed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
