gerlowskija commented on code in PR #826: URL: https://github.com/apache/solr/pull/826#discussion_r868391092
########## solr/modules/aws-secret-provider/README.md: ########## @@ -0,0 +1,80 @@ +Apache Solr - AWS Secret Provider +=========================== + +An implementation of `SecretCredentialsProvider` that pulls Zookeeper credentials from an AWS Secret Manager. + +This plugin uses the [default AWS credentials provider chain](https://docs.aws.amazon.com/sdk-for-java/v2/developer-guide/credentials.html), so ensure that your credentials are set appropriately (e.g., via env var, or in `~/.aws/credentials`, etc.). + +## Usage + +- To enable this feature copy the jar files in `modules/aws-secret-provider/lib` to `SOLR_INSTALL/server/solr-webapp/webapp/WEB-INF/lib/` and add follow the below steps before restarting Solr. Review Comment: I have a branch [here](https://github.com/gerlowskija/solr/commit/7468661cf94702b1dbc6386604de044b6bf26e70) that implements the "make an AWS-specific ZkCredentialsInjector" idea. Like I said, I think this approach should be "safe" classpath wise and would be a smaller change conceptually for Solr to take on. But it's totally possible that you're right and I'm not seeing some issue here. If you still suspect this won't work, maybe we could kick the tires a bit on that branch and see what we find? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
