anshumg commented on code in PR #826: URL: https://github.com/apache/solr/pull/826#discussion_r868952490
########## solr/modules/aws-secret-provider/README.md: ########## @@ -0,0 +1,80 @@ +Apache Solr - AWS Secret Provider +=========================== + +An implementation of `SecretCredentialsProvider` that pulls Zookeeper credentials from an AWS Secret Manager. + +This plugin uses the [default AWS credentials provider chain](https://docs.aws.amazon.com/sdk-for-java/v2/developer-guide/credentials.html), so ensure that your credentials are set appropriately (e.g., via env var, or in `~/.aws/credentials`, etc.). + +## Usage + +- To enable this feature copy the jar files in `modules/aws-secret-provider/lib` to `SOLR_INSTALL/server/solr-webapp/webapp/WEB-INF/lib/` and add follow the below steps before restarting Solr. Review Comment: Just went through this again, and again :) I like the idea of creating a ZkCredentialsInjector impl that's AWS-specific, rather than creating the extra layer of indirection (SecretCredentialsProvider) as @gerlowskija suggested. This might pass tests, but would certainly need more tests and testing to check for places the completeness of this approach. What I really appreciate about the approach here is that it does keep changes within a reasonable limit considering what we're trying to accomplish here. I'll spend more time on this later this week and try testing this too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
