[
https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542664#comment-17542664
]
David Smiley commented on SOLR-14699:
-------------------------------------
[~nazerke], I think you proposed {{logid}} because you are looking at 8.x which
uses this parameter name but on master (where this change will land), it's
named {{prefix}} (and I'm the one who made this change). Definitely put this
prefix thing in here where it can be parsed easily instead of outside. It can
be empty in which case, omit it. Longer term (not in this issue), I'd like to
see it go away; It's nearly always either blank or designates a node level
admin API. Instead disambiguate the path with something more complete to thus
clarify if this request is at a node level or core (e.g. {{/admin/metrics}} vs.
{{/\{c\}/select}} ) where I propose a hypothetical template-like syntax and "c"
refers to a core/collection. Again, for another day/issue.
[~gus] Easy parse-ability is certainly a goal here! Thus rely on existing
specs and libs for those specs such as JSON or URLDecoder. Note that the URL
encoded params are very useful in this format because you can copy-paste into a
browser -- something I do very often and I imagine others do likewise. I don't
see how those curly brackets around params are needed since the param encoded
part (and all values here today, like {{status}}) end in a space.
[~nazerke] in your example the {{webpp}} is null -- so don't add it :-). I
suspect this may be from our fork and isn't necessarily representative of *the*
Solr 9.
> Solr request logs should escape names, values
> (SolrQueryResponse.getToLogAsString)
> ----------------------------------------------------------------------------------
>
> Key: SOLR-14699
> URL: https://issues.apache.org/jira/browse/SOLR-14699
> Project: Solr
> Issue Type: Improvement
> Components: logging
> Reporter: David Smiley
> Priority: Minor
>
> {{SolrQueryResponse.getToLogAsString}} encodes the NamedList into a String
> with simple space-separated pairs with name=value. However, it does no
> escaping/encoding, and as-such a value might itself contain spaces and
> equals. This is a problem if these logs are being parsed, and we'd like to
> ensure we do so correctly. Note that SolrLogPostTool (aka "postlogs") parses
> these logs.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
