[
https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542692#comment-17542692
]
Gus Heck commented on SOLR-14699:
---------------------------------
FWIW, I'm 100% ok with a pure json log line... Or one that is pure json after
an easy to identify point. These satisfy my criteria of easy parsing. If we're
going to have url encoding the parameters, then we need some way to easily
extract that so that the query can be reproduced (after removing things like
distrib=false etc). LogPostTool is for indexing logs, which is of course also
an important use case, but different from the use case I am describing. I'm not
against us having a log parsing tool, but right now LogPostTool appears to be
single threaded and adds the weight of a SolrInputDocument... Tools I've
written have consumed many GB of logs, leveraging 32 available processors was a
big benefit, and it was written to stream the output to disk to avoid holding
all the logs and their parsed representation in memory... Also updates and
non-query lines were filtered out... Hard to write a tool to cover all cases.
Let's make it easy for folks to write a tool that suits their needs.
> Solr request logs should escape names, values
> (SolrQueryResponse.getToLogAsString)
> ----------------------------------------------------------------------------------
>
> Key: SOLR-14699
> URL: https://issues.apache.org/jira/browse/SOLR-14699
> Project: Solr
> Issue Type: Improvement
> Components: logging
> Reporter: David Smiley
> Priority: Minor
>
> {{SolrQueryResponse.getToLogAsString}} encodes the NamedList into a String
> with simple space-separated pairs with name=value. However, it does no
> escaping/encoding, and as-such a value might itself contain spaces and
> equals. This is a problem if these logs are being parsed, and we'd like to
> ensure we do so correctly. Note that SolrLogPostTool (aka "postlogs") parses
> these logs.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
