cpoerschke commented on PR #931:
URL: https://github.com/apache/solr/pull/931#issuecomment-1184226533
> ... Do you mean by subcalssing the `CoreAdminHandler` and populate it
explicitly?
Yes, subclassing and explicit populating in the subclass would be one way
e.g. in `solrconfig.xml` simply this then:
```
<requestHandler name="/admin" class="com.ijioio.solr.CoreAdminHandler"/>
```
But if people can subclass then they can implement in whatever way suits
them and they might want their class to be configurable e.g. like this:
```
<requestHandler name="/admin"
class="com.ijioio.solr.ConfigurableCoreAdminHandler">
<str name="foo">com.ijioio.solr.action.FooAction</str>
<str name="bar">com.ijioio.solr.action.BarAction</str>
</requestHandler>
```
And following that thought further, if we think that configurable custom use
is better than non-configurable use then we could have the in-built
`CoreAdminHandler` support configuration e.g. something like this:
```
<requestHandler name="/admin"
class="org.apache.solr.handler.admin.CoreAdminHandler">
<lst name="customActions">
<str name="foo">com.ijioio.solr.action.FooAction</str>
<str name="bar">com.ijioio.solr.action.BarAction</str>
</lst>
</requestHandler>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
