ijioio commented on code in PR #931:
URL: https://github.com/apache/solr/pull/931#discussion_r923230962
##########
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##########
@@ -132,6 +133,14 @@ public static NodeConfig fromConfig(Path solrHome,
XmlConfigFile config, boolean
String nodeName = (String) entries.remove("nodeName");
if (Strings.isNullOrEmpty(nodeName) && cloudConfig != null) nodeName =
cloudConfig.getHost();
+ Map<String, String> coreAdminHandlerActions =
+ readNodeListAsNamedList(
+ config, "solr/coreAdminHandlerActions/*[@name]",
"<coreAdminHandlerActions>")
+ .asMap()
+ .entrySet()
+ .stream()
+ .collect(Collectors.toMap(item -> item.getKey(), item ->
item.getValue().toString()));
+
Review Comment:
Yes, exactly! Initially I was also trying to make it inside
`fillSolrSection` but it doesn't fits quite nice there :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
