ijioio commented on code in PR #931:
URL: https://github.com/apache/solr/pull/931#discussion_r924034447


##########
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##########
@@ -190,7 +212,7 @@ public void handleRequestBody(SolrQueryRequest req, 
SolrQueryResponse rsp) throw
 
       // Pick the action
       final String action = req.getParams().get(ACTION, 
STATUS.toString()).toLowerCase(Locale.ROOT);
-      CoreAdminOperation op = opMap.get(action);
+      CoreAdminOp op = opMap.get(action);
       if (op == null) {
         handleCustomAction(req, rsp);

Review Comment:
   I think maybe using message with `warn` severity would be better here? I 
added following at the moment:
   
   ```java
         log.warn("action '{}' not found, calling custom action handler. "
             + "If original intention was to target some custom behaviour "
             + "use custom actions defined in 'solr.xml' instead", action);
   ```
   
   Feel free to apply any changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to