ijioio commented on code in PR #931:
URL: https://github.com/apache/solr/pull/931#discussion_r928107921
##########
solr/core/src/test/org/apache/solr/core/TestSolrXml.java:
##########
@@ -382,6 +405,26 @@ public void
testFailAtConfigParseTimeWhenSolrConfigParamsAreDuplicated() {
SolrXmlConfig.fromString(solrHome, solrXml); // return not used, only for
validation
}
+ public void
testFailAtConfigParseTimeWhenCoreAdminHandlerActionsConfigParamsAreDuplicated()
{
+ String v1 = "" + random().nextInt();
+ String v2 = "" + random().nextInt();
+ String solrXml =
+ String.format(
+ Locale.ROOT,
+ "<solr><coreAdminHandlerActions>"
+ + "<str name=\"action\">%s</str>"
+ + "<str name=\"action\">%s</str>"
+ + "</coreAdminHandlerActions></solr>",
+ v1,
+ v2);
Review Comment:
I think the format internals anyway will do the same conversion. I based the
method on others similar ones, so if we are going to change it, we should
better change all of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
